Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "khalid/precommit hooks" #5324

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Revert "khalid/precommit hooks" #5324

merged 1 commit into from
Apr 27, 2022

Conversation

matin-deriv
Copy link
Contributor

Reverts #5171 due to problems with cfd and accounts package on ts files

@vercel
Copy link

vercel bot commented Apr 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 3:13PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5324](https://github.com/binary-com/deriv-app/pull/5324)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-5171-precommit-hooks.binary.sx?qa_server=frontend.binaryws.com&app_id=23847
    - **Original**: https://deriv-app-git-revert-5171-precommit-hooks.binary.sx
- **App ID**: `23847`

@codecov-commenter
Copy link

Codecov Report

Merging #5324 (e4a8aa5) into master (5041008) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5324   +/-   ##
=======================================
  Coverage   13.32%   13.32%           
=======================================
  Files        1283     1283           
  Lines       29061    29061           
  Branches     4906     4906           
=======================================
  Hits         3871     3871           
  Misses      24952    24952           
  Partials      238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5041008...e4a8aa5. Read the comment docs.

@matin-deriv matin-deriv merged commit 7a80c86 into master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
@matin-deriv @sandeep-deriv
Revert "khalid/precommit hooks (deriv-com#5171)" (deriv-com#5324)
977518f 
This reverts commit 5041008.
@nijil-deriv nijil-deriv deleted the revert-5171-precommit-hooks branch October 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@njazuli-deriv njazuli-deriv Awaiting requested review from njazuli-deriv

@bahar-sadeghzadeh bahar-sadeghzadeh Awaiting requested review from bahar-sadeghzadeh

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@akmal-deriv akmal-deriv Awaiting requested review from akmal-deriv akmal-deriv is a code owner

@carolsachdeva carolsachdeva Awaiting requested review from carolsachdeva

@mehrzad-fs mehrzad-fs Awaiting requested review from mehrzad-fs

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
Account AppStore Bot Components Core P2P Shared Trader Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matin-deriv @codecov-commenter